Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/19512 )

Change subject: [docs] Add release notes for 1.17.0
......................................................................


Patch Set 10:

(29 comments)

Thank you for revving the release notes document!

It now looks much better, just several nits left.

http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc
File docs/release_notes.adoc:

http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@195
PS10, Line 195: tool
nit: drop 'tool' for brevity


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@239
PS10, Line 239: before Kudu 1.12
replace with:

the latter is for Kudu servers of releases prior to 1.12


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@241
PS10, Line 241: flag
flagging


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@248
PS10, Line 248: by `--show_slow_scans`
by tweaking the `--show_slow_scans` flag for tablet servers


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@256
PS10, Line 256: It's no longer necessary
It's not necessary


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@260
PS10, Line 260: to build and run
building and running


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@265
PS10, Line 265: Fixed an issue where historical MVCC data older than the 
ancient history mark (configured by
              : setting `--tablet_history_max_age_sec`) which has only delete 
operations without any update
              : operations hasn't been compacted correctly, then the ancient 
history data can not be GCed if the
              : tablet is created before Kudu 1.10 at which version doesn’t 
support live row counting
Fixed an issue where historical MVCC data older than the ancient history mark 
(configured by `--tablet_history_max_age_sec`) that had only DELETE operations 
wouldn't be compacted correctly. As a result, the ancient history data could 
not be GCed if the tablet had been created by Kudu servers of releases prior to 
1.10 (those versions did not support live row counting).


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@271
PS10, Line 271: crashes
could potentially crash


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@273
PS10, Line 273: Fixed a hang bug in the Kudu tablet server that is started by a 
user who has no permission of the
              : tablet metadata file
Fixed a bug when a Kudu tablet server started under an OS account that had no 
permission to access tablet metadata files would stuck in the tablet 
bootstrapping phase.


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@276
PS10, Line 276: doesn’t
would not


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@278
PS10, Line 278: doesn’t
would not


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@280
PS10, Line 280: Fixed a bug in the Java client where reading repetitive rows 
even if in fault tolerant scan mode
Fixed a bug in the Java client where under certain conditions same rows would 
be returned multiple times even if the scanner was configured to be 
fault-tolerant.


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@282
PS10, Line 282: don't
              : update
would not be updated


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@285
PS10, Line 285: can't
would not


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@287
PS10, Line 287: where Hive failed to query on Kudu tables
that was causing failures when scanning Kudu tables from Hive


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@290
PS10, Line 290: CLI tool `kudu table copy` failed to copy
... the `kudu table copy` CLI tool would fail copying ...


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@292
PS10, Line 292: CLI tool `kudu master unsafe_rebuild` failed to rebuild the 
correct latest
              : schema when the table to be rebuilt is unhealthy
... the `kudu master unsafe_rebuild` CLI tool would rebuild the system catalog 
with outdated schemas of tables that were unhealthy during the rebuild process


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@295
PS10, Line 295: which have
that had


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@295
PS10, Line 295: varchar
nit: VARCHAR


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@295
PS10, Line 295: string
nit: STRING


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@295
PS10, Line 295: binary
nit: BINARY


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@299
PS10, Line 299: that `kudu table copy` crashes
of the `kudu table copy` CLI tool crashing


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@300
PS10, Line 300: now it will exit gracefully and leave some helpful logs.
The tool now exits gracefully and provides additional information to 
troubleshooting in such a condition.


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@299
PS10, Line 299: when encountered an error when copy rows to the
              : destination table,
if encountering an error while copying rows to the destination table.


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@302
PS10, Line 302: crashes if the `--list_detail` flag is
              : enabled
would crash if the `--list_detail` flag was enabled


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@305
PS10, Line 305: of the Ranger client subprocess on Kudu master when receiving a 
response exceeds the
              : maximum message size, now it's able to clear the communication 
channel to receive next messages from
              : the subprocess
when a sub-process running Ranger client would crash when receiving a oversized 
message from Kudu master.  With the fix, each peer communicating via the 
Subprocess protocol now discards an oversized message, logs about the issue, 
and clears the channel, and is able to receive further messages after 
encountering such a condition.


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@309
PS10, Line 309: of a crash with SIGILL signal when attempt to run an 
application linked with
              : kudu_client library at a machine lacking SSE4.2 support
when a Kudu application linked with kudu_client library would crash with SIGILL 
if running on a machine lacking SSE4.2 support


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@343
PS10, Line 343:  If not, use new APIs introduced by Kudu 1.17.
I'm not sure why to add this -- this is quite strange.  If we are declaring 
that our Java client is compatible with 1.16 version both for the API and ABI, 
why to add this at all?  Does it mean the prior sentence is actually false?


http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@349
PS10, Line 349:  If not, use new APIs introduced by Kudu 1.17.
Ditto: why to add this if the prior sentence is true?



--
To view, visit http://gerrit.cloudera.org:8080/19512
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: comment
Gerrit-Change-Id: I4381e7824dcf7f500165aa3af9dca09a86ac1dd9
Gerrit-Change-Number: 19512
Gerrit-PatchSet: 10
Gerrit-Owner: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Ashwani Raina <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Hongjiang Zhang <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: KeDeng <[email protected]>
Gerrit-Reviewer: Khazar Mammadli <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Wang Xixu <[email protected]>
Gerrit-Reviewer: Wenzhe Zhou <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Yuqi Du <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: bsglz <[email protected]>
Gerrit-Reviewer: harinreddy <[email protected]>
Gerrit-Reviewer: yejiabao <[email protected]>
Gerrit-Reviewer: zhanghongbin <[email protected]>
Gerrit-Reviewer: Ádám Bakai <[email protected]>
Gerrit-Comment-Date: Mon, 19 Jun 2023 17:11:28 +0000
Gerrit-HasComments: Yes

Reply via email to