Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/19512 )
Change subject: [docs] Add release notes for 1.17.0 ...................................................................... Patch Set 11: (5 comments) Almost there. Just a few nits left. http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@343 PS10, Line 343: brary Compatibility > Wenzhe Zhou gave me some suggestions in PS1, "Applications which call the n I see. Sure: regarding the 'vice-versa' part, that's indeed so: applications using the newly added API wouldn't compile against prior versions of the library where if the API is absent in the prior versions. Maybe, it makes sense to clean this up a bit, because mixing those parts together leads adding that extra sentence, which seems to be related to both the backward and forward compatibility, so it looks a bit confusing to readers. Let's then remove that 'vice-versa' piece, maybe? I'd suggest to replace this sentence with the following: The Kudu 1.17 Java client library is API- and ABI-compatible with Kudu 1.16. Applications written against Kudu 1.16 will compile and run against the Kudu 1.17 client library. Applications written against Kudu 1.17 will compile and run against the Kudu 1.16 client library unless they use the API newly introduced in Kudu 1.17. http://gerrit.cloudera.org:8080/#/c/19512/10/docs/release_notes.adoc@349 PS10, Line 349: cpp} client is API- and ABI-forward-compatible > Same. Yup, and then let's update this part as well, please: The Kudu 1.17 {cpp} client is API- and ABI-forward-compatible with Kudu 1.16. Applications written and compiled against the Kudu 1.16 client library will run without modification against the Kudu 1.17 client library. Applications written and compiled against the Kudu 1.17 client library will run without modification against the Kudu 1.16 client library unless they use the API newly introduced in Kudu 1.17. http://gerrit.cloudera.org:8080/#/c/19512/11/docs/release_notes.adoc File docs/release_notes.adoc: http://gerrit.cloudera.org:8080/#/c/19512/11/docs/release_notes.adoc@117 PS11, Line 117: . nit: add space after the period http://gerrit.cloudera.org:8080/#/c/19512/11/docs/release_notes.adoc@187 PS11, Line 187: Optimized in-list predicate values based on RowSet PK bounds, it‘s possible to skip rows : effectively when the predicate is on a non-prefix of the primary key and the leading column(s) have : cardinality=1 Optimized evaluating in-list predicates based on RowSet PK bounds. A tablet server can now effectively skip rows when the predicate is on a non-prefix part of the primary key and the leading columns' cardinality is 1 http://gerrit.cloudera.org:8080/#/c/19512/11/docs/release_notes.adoc@260 PS11, Line 260: Experimentally supported building and running Kudu on Apple M chips and macOS 11, 12 Kudu can now be built and run on Apple M chips and macOS 11, 12. As with prior releases, Kudu's support for macOS is experimental, and should only be used for development. -- To view, visit http://gerrit.cloudera.org:8080/19512 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: comment Gerrit-Change-Id: I4381e7824dcf7f500165aa3af9dca09a86ac1dd9 Gerrit-Change-Number: 19512 Gerrit-PatchSet: 11 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Hongjiang Zhang <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Khazar Mammadli <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: bsglz <[email protected]> Gerrit-Reviewer: harinreddy <[email protected]> Gerrit-Reviewer: yejiabao <[email protected]> Gerrit-Reviewer: zhanghongbin <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Tue, 20 Jun 2023 18:05:02 +0000 Gerrit-HasComments: Yes
