Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: [KUDU-3483] Fixbug of auto flush data when table schema changed ...................................................................... Patch Set 15: (3 comments) http://gerrit.cloudera.org:8080/#/c/19949/15//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19949/15//COMMIT_MSG@9 PS15, Line 9: In auto_flush_background mode, applying an operation firstly : inserts the row into the buffer. When the buffer is full or : function flush() is called, it tries to flush multiple data into : Kudu server. Kudu client also sends batched write operations in MANUAL_FLUSH mode. Does this issue only happen in AUTO_FLUSH_BACKGROUND mode? http://gerrit.cloudera.org:8080/#/c/19949/15/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: http://gerrit.cloudera.org:8080/#/c/19949/15/java/kudu-client/src/main/java/org/apache/kudu/Schema.java@487 PS15, Line 487: public int hashCode() { I didn't see the use of this method. Is it related to this patch? http://gerrit.cloudera.org:8080/#/c/19949/15/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19949/15/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@418 PS15, Line 418: // Compare with the lastest schema in the list, because the lastest operations : // have the same schemas with it most likely. How about batching all of the buffered operations into their respective tablet and table schema? I think it's possible that the table schema can be changed multiple times during writing data to the table, so only comparing with the latest batch's schema may be not enough. -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 15 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 20 Jun 2023 09:19:33 +0000 Gerrit-HasComments: Yes
