Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/19949 )
Change subject: KUDU-3483 Fix flushing data in batch when table schema changed ...................................................................... Patch Set 16: (2 comments) http://gerrit.cloudera.org:8080/#/c/19949/16//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19949/16//COMMIT_MSG@16 PS16, Line 16: If two rows have different schema but belongs to the same : tablet, According to the newly added tests in this patch, this only happens when the table schema is altered during writing data to a table. In such cases, from my perspective, the user applications should be resilient to any errors introduced by the schema change. http://gerrit.cloudera.org:8080/#/c/19949/15/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java File java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java: http://gerrit.cloudera.org:8080/#/c/19949/15/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java@418 PS15, Line 418: // Compare with the last schema in the list, because the last operations : // have the same schemas with it most likely. > The batches are put into the list in the same order of operations, so regul We allow concurrent flushes from the client via the same KuduSession for throughput reasons, so maybe 'most likely' is not always true. -- To view, visit http://gerrit.cloudera.org:8080/19949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie6501962b32814d121f180b2942999c402d927db Gerrit-Change-Number: 19949 Gerrit-PatchSet: 16 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Sun, 25 Jun 2023 07:19:37 +0000 Gerrit-HasComments: Yes
