Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20079 )
Change subject: [build] Change shebangs to python3 ...................................................................... Patch Set 1: > > Patch Set 1: > > > > > > Patch Set 1: > > > > > > > > > (1 comment) > > > > > > > > It would be great to keep compatibility -- all existing Kudu > > > Python scripts work with Python2 as well if they work with > Python3. > > > We have spent time and effort on that, and I'm not sure we > want to > > > abandon that effort in the nearest future since we still have > bunch > > > of systems that on Python2. > > > > > > > > Yes, Python community decided to abandon Python2 because > they > > > don't want to spent resources on maintaining compatibility, > but > > > that's not in our interests as of now. > > > > > > While I do not agree that we should keep Python2 compatibility > > > alive, this change is not user facing. The changes only affect > > > thirdparty and build-support python files, so users who run > Kudu on > > > environments with Python2 would not be affected. I believe the > > > number of end-users who compile their own Kudu is rather > small, and > > > upgrading a build environment to also run Python3 (e.g. with > pyenv) > > > should not be as impactful as upgrading on edge/client nodes. > > > > Adding a symlink or running update-alternatives isn't a big deal > either. > > > > The affected people are Kudu developers, and I one of those. If > you don't do much development in Kudu on platforms which are still > python2-based, that's fine, but there are other people around you > who will be affected. > > So are you saying we should maintain two versions of these scripts > and switch between them depending on the developer's environment? I meant to keep our python script to be as they are, working both for Python2 and Python3. If switching to Python3, it's also necessary to do so for all the scripts, update the upstream CI infra, and also update various docs and revise the list of OSes that Kudu claims to support. Even if Python2 declared as phased out, the systems like Ubuntu18 are still supported by Kudu and have python2 by default, and you can see that Ubuntu18 has been supported by Canonical till May 31 2023, but it will be supported for subscription-based customers till 2026. -- To view, visit http://gerrit.cloudera.org:8080/20079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I824daa0cf151e89f783db98d46fb23ce9e267093 Gerrit-Change-Number: 20079 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 22 Jun 2023 20:26:30 +0000 Gerrit-HasComments: No
