Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20079 )
Change subject: [build] Change shebangs to python3 ...................................................................... Patch Set 1: > > Patch Set 1: > > > > > > Patch Set 1: > > > > > > > > > (1 comment) > > > > > > > > It would be great to keep compatibility -- all existing Kudu > > > Python scripts work with Python2 as well if they work with > Python3. > > > We have spent time and effort on that, and I'm not sure we > want to > > > abandon that effort in the nearest future since we still have > bunch > > > of systems that on Python2. > > > > > > > > Yes, Python community decided to abandon Python2 because > they > > > don't want to spent resources on maintaining compatibility, > but > > > that's not in our interests as of now. > > > > > > While I do not agree that we should keep Python2 compatibility > > > alive, this change is not user facing. > > > > So, you don't agree we should keep Python2 compatibility? You > mean you'd rather break the compatibility? Why? What's wrong with > keeping things compatible between major Python versions? > > I think it provides diminishing returns, we'll have to keep > spending time and effort to be able to build with both Python > versions. In turn the number of Python2 users will decrease in > time. It would simplify solving build issues in the future if we > only need to focus on one version. > We'll have to abandon Python2 at one point, maybe that point is not > now, but it has to be considered. > > > > > > The changes only affect > > > thirdparty and build-support python files, so users who run > Kudu on > > > environments with Python2 would not be affected. > > > > That's simply not true that those files only affect thirdparty > and build-support stuff. The gen_version_info.py script is used > every time when you build Kudu bits, not just third-party. > > You're right, I overlooked the gen_version_info.py, however it > still holds that these are build time only, so end users can still > use the released bits with Python2 environments. Just FYI, Apache Kudu provides no binary artifacts apart from Docker images that might be used just for toy and POC clusters. Any "end user" of the Apache Kudu project eventually ends up compiling Kudu from source if they want to have Kudu binaries, and if their system is based on python2, they will be left in dark if this patch is pushed. -- To view, visit http://gerrit.cloudera.org:8080/20079 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I824daa0cf151e89f783db98d46fb23ce9e267093 Gerrit-Change-Number: 20079 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 22 Jun 2023 21:11:51 +0000 Gerrit-HasComments: No
