Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 )
Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/20084/6/src/kudu/common/schema.cc File src/kudu/common/schema.cc: PS6: Shouldn't this be a part of other patch in this stack of patches, with corresponding test coverage? Doesn't C++ client choke in similar case? If not, why similar check isn't present in the C++ client and does it make sense to add similar check in there as well? http://gerrit.cloudera.org:8080/#/c/20084/6/src/kudu/common/schema.cc@313 PS6, Line 313: the check to check http://gerrit.cloudera.org:8080/#/c/20084/6/src/kudu/common/schema.cc@313 PS6, Line 313: for number for the number http://gerrit.cloudera.org:8080/#/c/20084/6/src/kudu/common/schema.cc@317 PS6, Line 317: != nit: add spaces around '!=' operation -- To view, visit http://gerrit.cloudera.org:8080/20084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I929d54d22c1c938ee67fdda9f4c2bb68c028b4ec Gerrit-Change-Number: 20084 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 23 Jun 2023 06:53:58 +0000 Gerrit-HasComments: Yes
