Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/20084 )
Change subject: KUDU-1945 Backup/restore for tables with auto incrementing columns ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/20084/6/src/kudu/common/schema.cc File src/kudu/common/schema.cc: PS6: > Shouldn't this be a part of other patch in this stack of patches, with corr The intention of having it here is to have it close to where it was discovered that it was needed for future references. I can add it to the client side patches with a. test coverage, sure. The stripping was introduced to overcome a limitation in Java client: https://gerrit.cloudera.org/#/c/3015/ There was a note worthy discussion here: https://gerrit.cloudera.org/#/c/12689/6/java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduScanner.java@323 I guess the technical debt (TODO) was never addressed and should be addressed to iron out the implementation. -- To view, visit http://gerrit.cloudera.org:8080/20084 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I929d54d22c1c938ee67fdda9f4c2bb68c028b4ec Gerrit-Change-Number: 20084 Gerrit-PatchSet: 6 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Fri, 23 Jun 2023 22:27:35 +0000 Gerrit-HasComments: Yes
