Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20050 )
Change subject: KUDU-3448 Add support for encrypting existing keys ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/20050/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/20050/5/src/kudu/master/catalog_manager.cc@1351 PS5, Line 1351: : MAYBE_INJECT_RANDOM_LATENCY(FLAGS_catalog_manager_inject_latency_load_ca_info_ms > The idea is to move this 're-encrypt' logic at the level of InitCertAuthori That's a good point, changed it. http://gerrit.cloudera.org:8080/#/c/20050/6/src/kudu/master/sys_catalog.cc File src/kudu/master/sys_catalog.cc: http://gerrit.cloudera.org:8080/#/c/20050/6/src/kudu/master/sys_catalog.cc@933 PS6, Line 933: CHECK_OK(row.SetInt8(kSysCatalogTableColType, CERT_AUTHORITY_INFO)); : CHECK_OK(row.SetStringNoCopy(kSysCatalogTableColId, kSysCertAuthorityEntryId)); : CHECK_OK(row.SetStringNoCopy(kSysCatalogTableColMetadata, metadata_buf)); : RowOperationsPBEncoder enc(req.mutable_row_operations()); : enc.Add(op, row); : : return SyncWrite(req); : } : : : : Status SysCatalogTable::AddTskEntry(const SysTskEntryPB& entry) { : WriteRequestPB req; : req.set_tablet_id(kSysCatalogTabletId); : CHECK_OK(SchemaToPB(schema_, req.mutable_schema())); : > Is it possible to have an utility method that's parameterized by the operat Done -- To view, visit http://gerrit.cloudera.org:8080/20050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide6ec4fb86325897f2b011aee9643d276044279d Gerrit-Change-Number: 20050 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 23 Jun 2023 13:54:45 +0000 Gerrit-HasComments: Yes
