Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20050 )
Change subject: KUDU-3448 Add support for encrypting existing keys ...................................................................... Patch Set 12: (3 comments) http://gerrit.cloudera.org:8080/#/c/20050/10/src/kudu/integration-tests/security-itest.cc File src/kudu/integration-tests/security-itest.cc: http://gerrit.cloudera.org:8080/#/c/20050/10/src/kudu/integration-tests/security-itest.cc@1161 PS10, Line 1161: SKIP_IF_SLOW_NOT_ALLOWED(); > nit: does it make sense to add SKIP_IF_SLOW_NOT_ALLOWED() here since this s Done http://gerrit.cloudera.org:8080/#/c/20050/10/src/kudu/integration-tests/security-itest.cc@1166 PS10, Line 1166: ASSERT_OK(cluste > nit for here and below for SmokeTestCluster() call sites: does it make sens Done http://gerrit.cloudera.org:8080/#/c/20050/10/src/kudu/integration-tests/security-itest.cc@1179 PS10, Line 1179: } : cluster_->Shutdown(); > nit: it would be great to have a small comment to explain why timeout is ex Done -- To view, visit http://gerrit.cloudera.org:8080/20050 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ide6ec4fb86325897f2b011aee9643d276044279d Gerrit-Change-Number: 20050 Gerrit-PatchSet: 12 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 26 Jun 2023 20:30:12 +0000 Gerrit-HasComments: Yes
