KeDeng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20182 )
Change subject: [compile] fix a compile warning ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc File src/kudu/integration-tests/auto_incrementing-itest.cc: http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc@530 PS1, Line 530: j = (j + 1) % kNumTabletServers; : } > However, this implementation would cause the variable j to remain > unchanged in the next loop. I am very sorry that my previous reply was not well thought out, but the message cannot be deleted now. I have made the modifications according to your suggestion, and I really appreciate your review. http://gerrit.cloudera.org:8080/#/c/20182/1/src/kudu/integration-tests/auto_incrementing-itest.cc@530 PS1, Line 530: j = (j + 1) % kNumTabletServers; : } > Would it be more readable if written simply as Done -- To view, visit http://gerrit.cloudera.org:8080/20182 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I125674ad3bfcc14ae5077b84d6f3d01fcacd1e08 Gerrit-Change-Number: 20182 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 11 Jul 2023 14:00:23 +0000 Gerrit-HasComments: Yes
