Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20183 )
Change subject: [compile] fix a compile warning ...................................................................... Patch Set 2: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20183/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20183/2//COMMIT_MSG@16 PS2, Line 16: Although it does not involve functional defects, it : still needs to be fixed. While it's good to have no warnings during compilation, I'm not sure it makes sense to fix every bogus warnings like this by actually modifying the code. IIUC, that's just a bug in particular GCC version, so the compiler warns about an issue that doesn't exist in reality. Did you explore other, less invasive alternatives to quell this bogus warning, like pragma statements? Or you'd rather prefer updating the code like that for some reason? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/20183 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib2c3d430b26e4c7961a54894429e09938c7ed692 Gerrit-Change-Number: 20183 Gerrit-PatchSet: 2 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 20 Jul 2023 03:56:08 +0000 Gerrit-HasComments: Yes
