Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20166 )
Change subject: KUDU-3407: Give a chance to do other maintenance operations while server is under memory pressure. ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/20166/7/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20166/7/src/kudu/util/maintenance_manager-test.cc@922 PS7, Line 922: TEST_F(MaintenanceManagerTest, TestNotFlushMemory) { Did you run any practical workloads to see other maintenance ops in action when memory usage is high? I want to understand the impact of not choosing flush ops when memory usage is high for long time. Also, what factors are to be kept in mind when deciding to increase/decrease a probability of running flush ops? http://gerrit.cloudera.org:8080/#/c/20166/7/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/20166/7/src/kudu/util/maintenance_manager.cc@104 PS7, Line 104: 0 If this is going to be 0(i.e. DRS/MRS flush ops will be scheduled as per priority), you might want to think about providing some to hint to user that it is time to avoid flushing DRS and MRS when under memory pressure. -- To view, visit http://gerrit.cloudera.org:8080/20166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc2fd3a850cf99d54ef2980211b712468440ed80 Gerrit-Change-Number: 20166 Gerrit-PatchSet: 7 Gerrit-Owner: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Ashwani Raina <ara...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <songjiach...@thinkingdata.cn> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <1450306...@qq.com> Gerrit-Comment-Date: Fri, 14 Jul 2023 13:51:53 +0000 Gerrit-HasComments: Yes
