Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20166 )
Change subject: KUDU-3407 not always flush even if under memory pressure. ...................................................................... Patch Set 14: (7 comments) I added a test to show which operation the maintenance manager would like to choose in various policies and workloads, which is involved in KUDU-3488. Using the test, we could test all the operations and flags, including the newly added flag in this patch. http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager-test.cc File src/kudu/util/maintenance_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager-test.cc@336 PS9, Line 336: > The default value is 0, why set it again? Done http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.h File src/kudu/util/maintenance_manager.h: http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.h@382 PS9, Line 382: /// @param [out] used_memory_percentage > nit: used_memory_percentage Done http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc File src/kudu/util/maintenance_manager.cc: http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc@104 PS9, Line 104: run_non_memory_ops_pr > It is easy to be understand to use a positive flag. How about: run_non_memo Done http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc@107 PS9, Line 107: mory operations " > non-memory operations waiting to be ran. Done http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc@109 PS9, Line 109: ead of flushing ops. This might be needed to turn " : "on if maintainer found that the tablet server is under memory " : "pressure for a long time and > I think your purpose is to make a balance between running memory and non-me It is computed by the memory usage. Maintainer may set a certain value and the exact probability is calculated by the value and the memory usage. I think the only convincible factor is memory usage, other factors, like perf scores of operations, are not really reliable. http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc@111 PS9, Line 111: pressure for a > Reading or wring performance? Both, I think. Row set height is getting higher, redo files are getting larger, so both write performance and read performance might be worse. http://gerrit.cloudera.org:8080/#/c/20166/9/src/kudu/util/maintenance_manager.cc@112 PS9, Line 112: TAG_FLAG(run_non_memory_ops_prob, experimental > It should also add 'runtime' flag? Done -- To view, visit http://gerrit.cloudera.org:8080/20166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idc2fd3a850cf99d54ef2980211b712468440ed80 Gerrit-Change-Number: 20166 Gerrit-PatchSet: 14 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Thu, 24 Aug 2023 09:05:17 +0000 Gerrit-HasComments: Yes
