Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20219 )
Change subject: KUDU-1945 Update Default Range partition Key ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/20219/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20219/1//COMMIT_MSG@9 PS1, Line 9: primary keys columns of the primary key? http://gerrit.cloudera.org:8080/#/c/20219/1/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/20219/1/src/kudu/common/partition-test.cc@2316 PS1, Line 2316: TEST_F(PartitionTest, PartitionKeyWithAutoIncrementingColumn) { It would be great to provide a small blurb describing what is the essence of this scenario. Is my understanding correct that this test would fail without the corresponding change in partition.cc that's a part of this patch? http://gerrit.cloudera.org:8080/#/c/20219/1/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/20219/1/src/kudu/common/partition.cc@277 PS1, Line 277: if (schema.auto_incrementing_col_idx() != column_idx) { BTW, have you checked out other places in the code where RangeSchema::column_ids field is populated? I'm also curious whether it's necessary to revise other places where that field is being used. E.g., does PartitionSchema::PartitionMayContainRow() needs to be updated as well? -- To view, visit http://gerrit.cloudera.org:8080/20219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89818ceb261064369a63712f6c093f41e57ca5cc Gerrit-Change-Number: 20219 Gerrit-PatchSet: 1 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Wed, 19 Jul 2023 01:10:25 +0000 Gerrit-HasComments: Yes
