Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20219 )
Change subject: KUDU-1945 Update default range partition key ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20219/3/src/kudu/common/partition-test.cc File src/kudu/common/partition-test.cc: http://gerrit.cloudera.org:8080/#/c/20219/3/src/kudu/common/partition-test.cc@2333 PS3, Line 2333: ASSERT_EQ("HASH (c1) PARTITIONS 2, RANGE (c1)" Doesn't this look strange and quite unexpected that the resulted partitioning is a two-tiered one, when the request was to create one-tiered hash partitioning? http://gerrit.cloudera.org:8080/#/c/20219/1/src/kudu/common/partition.cc File src/kudu/common/partition.cc: http://gerrit.cloudera.org:8080/#/c/20219/1/src/kudu/common/partition.cc@277 PS1, Line 277: if (schema.auto_incrementing_col_idx() != column_idx) { > Yes, I manually looked through all the occurrences of RangeSchema range_sch Thanks you for the clarification. -- To view, visit http://gerrit.cloudera.org:8080/20219 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I89818ceb261064369a63712f6c093f41e57ca5cc Gerrit-Change-Number: 20219 Gerrit-PatchSet: 3 Gerrit-Owner: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Abhishek Chennaka <achenn...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <ale...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <mre...@cloudera.com> Gerrit-Comment-Date: Thu, 20 Jul 2023 17:22:33 +0000 Gerrit-HasComments: Yes
