Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20163 )
Change subject: [Client] Make row errors more readable ...................................................................... Patch Set 3: Code-Review+1 (6 comments) Thank you for the patch! http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG@7 PS3, Line 7: Client java client http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG@9 PS3, Line 9: maybe may http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG@9 PS3, Line 9: Flush Flushing http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG@10 PS3, Line 10: You can know the error detail by session.getPendingErrors() : .getRowErrors(). But it returns an unreadable information. It's possible get the error details by calling KuduSession.getPendingErrors(), but it doesn't present the information in a human-readable form. http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG@18 PS3, Line 18: debuging debugging http://gerrit.cloudera.org:8080/#/c/20163/3/java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java: http://gerrit.cloudera.org:8080/#/c/20163/3/java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java@103 PS3, Line 103: operation.getRow() Does it make sense to show only the primary key here, i.e. call stringifyRowKey() on PartialRow or you'd rather have all the columns printed out in the error message? -- To view, visit http://gerrit.cloudera.org:8080/20163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1170986ef9b40d83a6b6da8571d15d1c6bf4df97 Gerrit-Change-Number: 20163 Gerrit-PatchSet: 3 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 28 Jul 2023 16:46:07 +0000 Gerrit-HasComments: Yes
