Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20163 )
Change subject: [java client] Make row errors more readable ...................................................................... Patch Set 5: (7 comments) http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG@7 PS3, Line 7: java c > java client Done http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG@9 PS3, Line 9: Flush > Flushing Done http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG@9 PS3, Line 9: es ma > may Done http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG@10 PS3, Line 10: It's possible get the error details by calling : KuduSession.getPendingErrors(), but it doesn't present the > It's possible get the error details by calling KuduSession.getPendingErrors Done http://gerrit.cloudera.org:8080/#/c/20163/3//COMMIT_MSG@18 PS3, Line 18: > debugging Done http://gerrit.cloudera.org:8080/#/c/20163/3/java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java File java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java: http://gerrit.cloudera.org:8080/#/c/20163/3/java/kudu-client/src/main/java/org/apache/kudu/client/RowError.java@103 PS3, Line 103: operation.getRow() > Does it make sense to show only the primary key here, i.e. call stringifyRo It is better to have all the columns printed out in the error message. It is easy to distinguish delete operations and insert operations. Delete operations only contain primary key. And insert operations contain all columns. http://gerrit.cloudera.org:8080/#/c/20163/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java: http://gerrit.cloudera.org:8080/#/c/20163/3/java/kudu-client/src/test/java/org/apache/kudu/client/TestRowErrors.java@173 PS3, Line 173: > nit: Could these constant values be defined as final variables? Thx. Done -- To view, visit http://gerrit.cloudera.org:8080/20163 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1170986ef9b40d83a6b6da8571d15d1c6bf4df97 Gerrit-Change-Number: 20163 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Mon, 31 Jul 2023 02:05:08 +0000 Gerrit-HasComments: Yes
