Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/20288 )
Change subject: [common] minor optimization on ComputeHashBuckets ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20288/1/src/kudu/common/partition_pruner.cc File src/kudu/common/partition_pruner.cc: http://gerrit.cloudera.org:8080/#/c/20288/1/src/kudu/common/partition_pruner.cc@225 PS1, Line 225: if (std::all_of(hash_bucket_bitset->begin(), : hash_bucket_bitset->end(), : [](bool b) { return b; })) { : return; : } > Is it equal to the below? std::any_of will early return if find a false val Both are right. It seems no obvious distinction in algorithm implements for 'all_of' and 'any_of'. https://github.com/llvm-mirror/libcxx/blob/a12cb9d211019d99b5875b6d8034617cbc24c2cc/include/algorithm#L838 -- To view, visit http://gerrit.cloudera.org:8080/20288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iecd9a739f408646c0dab74727f919e4f6ce3ce7e Gerrit-Change-Number: 20288 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Tue, 01 Aug 2023 07:51:48 +0000 Gerrit-HasComments: Yes
