Yingchun Lai has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20288 )
Change subject: [common] minor optimization on ComputeHashBuckets ...................................................................... [common] minor optimization on ComputeHashBuckets It's enough to find the very first 'false' element in the boolean vector of selected predicate values to decide whether to continue with the code in PartitionPruner::ComputeHashBuckets(). Also, using std::all_of() might employ optimizations in the specialized implementation of std::vector<bool> container, if there were any. In addition, I looked at the possibility to use boost::dynamic_bitset instead of std::vector<bool> for PartitionPruner::PruneHashComponent() in this context, but it seems PruneHashComponent() isn't exactly at hot paths of reading and writing data. This is a follow-up to 5d6774b1022f26d33abd6cc9fb9950749084942 Change-Id: Iecd9a739f408646c0dab74727f919e4f6ce3ce7e Reviewed-on: http://gerrit.cloudera.org:8080/20288 Tested-by: Kudu Jenkins Reviewed-by: Mahesh Reddy <[email protected]> Reviewed-by: Yifan Zhang <[email protected]> Reviewed-by: Yuqi Du <[email protected]> Reviewed-by: Yingchun Lai <[email protected]> --- M src/kudu/common/partition_pruner.cc 1 file changed, 5 insertions(+), 6 deletions(-) Approvals: Kudu Jenkins: Verified Mahesh Reddy: Looks good to me, but someone else must approve Yifan Zhang: Looks good to me, approved Yuqi Du: Looks good to me, but someone else must approve Yingchun Lai: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/20288 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Iecd9a739f408646c0dab74727f919e4f6ce3ce7e Gerrit-Change-Number: 20288 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]>
