Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20320 )
Change subject: [consensus] clean-up on OpId utilities ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/20320/1/src/kudu/consensus/opid_util.h File src/kudu/consensus/opid_util.h: http://gerrit.cloudera.org:8080/#/c/20320/1/src/kudu/consensus/opid_util.h@58 PS1, Line 58: inline bool operator>(const OpId& lhs, const OpId& rhs) { Also, why not use the negation of the < operator above? http://gerrit.cloudera.org:8080/#/c/20320/1/src/kudu/consensus/opid_util.h@72 PS1, Line 72: inline bool operator>=(const OpId& lhs, const OpId& rhs) { Same as above comment but for <= operator, I guess it's only one line of code anyways so doesn't help there. -- To view, visit http://gerrit.cloudera.org:8080/20320 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iea1e7fba9d91ac9527d88721a867a856e8a858b3 Gerrit-Change-Number: 20320 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Tue, 08 Aug 2023 01:03:17 +0000 Gerrit-HasComments: Yes
