Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/20320 )
Change subject: [consensus] clean-up on OpId utilities
......................................................................
[consensus] clean-up on OpId utilities
This patch cleans up the code in opid_util.{cc,h} by removing unused
methods and introducing human-readable operators (there are in-lined)
to compare OpId instances.
The MinimumOpId() and MaximumOpId() helper functions have been updated
as well to return constant references to statically initialized
constants instead of creating OpId instances every time, setting
the term and index fields, and returning a copy. Related call sites
and methods of other classes have been updated correspondingly.
Change-Id: Iea1e7fba9d91ac9527d88721a867a856e8a858b3
Reviewed-on: http://gerrit.cloudera.org:8080/20320
Reviewed-by: Abhishek Chennaka <[email protected]>
Tested-by: Abhishek Chennaka <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Mahesh Reddy <[email protected]>
---
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/opid_util.cc
M src/kudu/consensus/opid_util.h
M src/kudu/consensus/pending_rounds.cc
M src/kudu/consensus/pending_rounds.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/consensus/raft_consensus.h
M src/kudu/consensus/raft_consensus_quorum-test.cc
M src/kudu/integration-tests/raft_consensus-itest.cc
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tablet/tablet_metadata.cc
12 files changed, 98 insertions(+), 187 deletions(-)
Approvals:
Abhishek Chennaka: Looks good to me, approved; Verified
Alexey Serbin: Verified
Mahesh Reddy: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/20320
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea1e7fba9d91ac9527d88721a867a856e8a858b3
Gerrit-Change-Number: 20320
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mahesh Reddy <[email protected]>
