Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20178 )
Change subject: KUDU-3326 disable compaction for soft-deleted table ...................................................................... Patch Set 3: (11 comments) http://gerrit.cloudera.org:8080/#/c/20178/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20178/3//COMMIT_MSG@9 PS3, Line 9: nit: Remove the extra space. http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/client/client-test.cc File src/kudu/client/client-test.cc: http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/client/client-test.cc@5396 PS3, Line 5396: nit: remove the blank line. http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/client/client-test.cc@5405 PS3, Line 5405: ASSERT_EVENTUALLY([&] () { Is the ASSERT_EVENTUALLY necessary? http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/client/client-test.cc@5419 PS3, Line 5419: soft_deleted nit: non solf deleted? http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/master/catalog_manager.h@1001 PS3, Line 1001: GC algorithm What does the "GC algorithm" here? http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/master/catalog_manager.cc@2639 PS3, Line 2639: soft_deleted How about unifying the name as "soft-deleted"? http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/master/catalog_manager.cc@2901 PS3, Line 2901: soft_deleted recalled ? http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/master/catalog_manager.cc@3396 PS3, Line 3396: nit: remove the extra space. http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/master/catalog_manager.cc@6044 PS3, Line 6044: LocalTimeAsString How about use the delete_timestamp field of "l.mutable_data()->pb" ? http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/master/catalog_manager.cc@6045 PS3, Line 6045: SOFT_DELETED Isn't the state of table changed in L2598, why change it again? http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/20178/3/src/kudu/master/master-test.cc@a3682 PS3, Line 3682: Why change these tests? -- To view, visit http://gerrit.cloudera.org:8080/20178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I060810051613a19e6f5c6506effda2d698528839 Gerrit-Change-Number: 20178 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 14 Aug 2023 16:36:56 +0000 Gerrit-HasComments: Yes
