Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/20178 )
Change subject: KUDU-3326 disable compaction for soft-deleted table ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/20178/5/src/kudu/master/catalog_manager.h File src/kudu/master/catalog_manager.h: http://gerrit.cloudera.org:8080/#/c/20178/5/src/kudu/master/catalog_manager.h@713 PS5, Line 713: bool force_deal_soft_deleted_table = false); How about use an enum instead of boolean to clarify the meaning? http://gerrit.cloudera.org:8080/#/c/20178/5/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/20178/5/src/kudu/master/catalog_manager.cc@6039 PS5, Line 6039: to running The comments need to be updated. -- To view, visit http://gerrit.cloudera.org:8080/20178 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I060810051613a19e6f5c6506effda2d698528839 Gerrit-Change-Number: 20178 Gerrit-PatchSet: 5 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Mon, 21 Aug 2023 05:21:30 +0000 Gerrit-HasComments: Yes
