Hello Alexey Serbin, Abhishek Chennaka,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/20365
to review the following change.
Change subject: KUDU-3504 Crash master on subprocess death
......................................................................
KUDU-3504 Crash master on subprocess death
In the past, there were several instances when the subprocess crashed.
In these cases, the master happily went on, but failed to authorize
requests. Since there's no way to restart the subprocess without
restarting the master anyway, it's better to crash the master as well to
make sure the failure of the subprocess is detected in time and can be
addressed.
Also, a follow-up patch will add the possibility to add extra JVM
arguments, which can easily cause the subprocess to fail to actually
start after forking. Its tests cover this new behavior as well.
Change-Id: Iec516f3d684f152bd29874b60b810c526ee5a184
---
M src/kudu/subprocess/server.cc
M src/kudu/subprocess/server.h
M src/kudu/subprocess/subprocess_proxy.h
3 files changed, 42 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/65/20365/1
--
To view, visit http://gerrit.cloudera.org:8080/20365
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec516f3d684f152bd29874b60b810c526ee5a184
Gerrit-Change-Number: 20365
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
