Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20365 )
Change subject: KUDU-3504 Crash master on subprocess death ...................................................................... Patch Set 7: (2 comments) http://gerrit.cloudera.org:8080/#/c/20365/6/src/kudu/subprocess/server.cc File src/kudu/subprocess/server.cc: http://gerrit.cloudera.org:8080/#/c/20365/6/src/kudu/subprocess/server.cc@399 PS6, Line 399: > What about checking for the return code here? At least, I'd think you need Good point, added a check. Subprocess::Wait() resulted in a data race as reported by TSAN, so apparently DoWait() is not thread-safe (and probably doesn't need to be). Added a note about this. http://gerrit.cloudera.org:8080/#/c/20365/6/src/kudu/util/subprocess.cc File src/kudu/util/subprocess.cc: http://gerrit.cloudera.org:8080/#/c/20365/6/src/kudu/util/subprocess.cc@613 PS6, Line 613: ubstitute("Process $0 > nit: it could have exited on its own, no? If so, then maybe "process no lo Done -- To view, visit http://gerrit.cloudera.org:8080/20365 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iec516f3d684f152bd29874b60b810c526ee5a184 Gerrit-Change-Number: 20365 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 16 Aug 2023 12:04:24 +0000 Gerrit-HasComments: Yes
