Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20374 )
Change subject: [arm64] implement with native NEON instructions ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/20374/3/src/kudu/util/char_util.cc File src/kudu/util/char_util.cc: http://gerrit.cloudera.org:8080/#/c/20374/3/src/kudu/util/char_util.cc@57 PS3, Line 57: const __m128i mask = _mm_set1_epi32(0x80808080); > warning: narrowing conversion from constant value 2155905152 (0x80808080) o This isn't changed in this particular patch, so let's keep it 'as is' here. The warning might be addressed in a separate changelist. -- To view, visit http://gerrit.cloudera.org:8080/20374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id46816439d2741d1d095df4e53d6199ad7a9f6db Gerrit-Change-Number: 20374 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 08 Sep 2023 02:49:47 +0000 Gerrit-HasComments: Yes
