Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20374 )
Change subject: [arm64] implement with native NEON instructions ...................................................................... Patch Set 4: > Hi, > > We do not have an arm jenkins slave yet. (Hopefully we will have > one soon). > That is why I tried to test manually. > You could run the google tests (if you have not done it already) > Just run 'ninja test' (or 'make test', whatever you use). > If you already done so, then there is nothing to do. I will look at > it a bit more, then give you +1 (and maybe ping a commiter). For the record, I built and ran C++ tests with PS2 by executing 'ctest -j4' command (my ARM VM t4g.xlarge in EC2 had 4 CPU cores). Everything passes, except for a couple tests which are known flakes -- I re-run then separately and they passed as well. So, it looks good to me! -- To view, visit http://gerrit.cloudera.org:8080/20374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id46816439d2741d1d095df4e53d6199ad7a9f6db Gerrit-Change-Number: 20374 Gerrit-PatchSet: 4 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Anonymous Coward (763) Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 08 Sep 2023 03:34:30 +0000 Gerrit-HasComments: No
