Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20270 )
Change subject: KUDU-3461 [client] Avoid impala crash by returning error if invalid tablet id found ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/20270/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20270/10//COMMIT_MSG@9 PS10, Line 9: if Java client issued a DDL op : on the partition where data is inserted into the partition that was altered : by java client in between. > nit: the fact that the other client is Kudu _Java_ client isn't important a Done http://gerrit.cloudera.org:8080/#/c/20270/12/src/kudu/client/meta_cache.cc File src/kudu/client/meta_cache.cc: http://gerrit.cloudera.org:8080/#/c/20270/12/src/kudu/client/meta_cache.cc@552 PS12, Line 552: emote_tablet > Thanks for the detailed response and adding a check. The fact that we got a Status::NotFound() means there was no cache entry found for the covering tablet i.e. there is no tablet representing the key in question. For an infinite recursion condition to occur, the ingredients required are: 1. Tablet leader is to be found out for a query to redirect itself. Even though we will have a stale tablet id entry in the cache but there won't be any fresh cache entry present because the above lookup returned NotFound which means after the old entry went stale, the corresponding tablet for the key is not present anymore. 2. Batcher layer tagging an op with a tablet at the time when it accepts the op, happens only when there is a corresponding tablet present for the op's row's partition key. If there was no such tablet present at the time (NotFound case), we will not get past above mentioned batcher code and come here. -- To view, visit http://gerrit.cloudera.org:8080/20270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia09cf6fb1b1d10f1ad13a62b5c863bcd1e3ab26a Gerrit-Change-Number: 20270 Gerrit-PatchSet: 13 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Thu, 14 Sep 2023 14:34:16 +0000 Gerrit-HasComments: Yes
