Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20270 )
Change subject: KUDU-3461 [client] Avoid impala crash by returning error if invalid tablet id found ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/20270/8//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20270/8//COMMIT_MSG@31 PS8, Line 31: The last statement i.e. #8 causes impalad (connected to impala-shell) to crash : With this change, last statement query fails and throws "invalid tablet id" error. > It is still valid though we are checking against error code now instead of Correction: changed to "Status::InvalidArgument()" http://gerrit.cloudera.org:8080/#/c/20270/8//COMMIT_MSG@36 PS8, Line 36: expect it it return error > Added error code "kInvalidArgument" Correction: Changed to "Status::InvalidArgument()" -- To view, visit http://gerrit.cloudera.org:8080/20270 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia09cf6fb1b1d10f1ad13a62b5c863bcd1e3ab26a Gerrit-Change-Number: 20270 Gerrit-PatchSet: 8 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Mon, 28 Aug 2023 20:09:31 +0000 Gerrit-HasComments: Yes
