Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 )
Change subject: [KUDU-3447] Limit tablets copying speed ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/19479/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/19479/5//COMMIT_MSG@9 PS5, Line 9: an old cluster to another new cluster nit: one cluster to another http://gerrit.cloudera.org:8080/#/c/19479/5//COMMIT_MSG@13 PS5, Line 13: get impacted and become unavailable It is necessary to mention the reason, I guess it's because of the tablets copying process cost too much disk and/or network bandwith. http://gerrit.cloudera.org:8080/#/c/19479/5//COMMIT_MSG@15 PS5, Line 15: to balance How about: "a tradeoff of" http://gerrit.cloudera.org:8080/#/c/19479/5/thirdparty/build-definitions.sh File thirdparty/build-definitions.sh: http://gerrit.cloudera.org:8080/#/c/19479/5/thirdparty/build-definitions.sh@1248 PS5, Line 1248: build_folly() { Have you ever try class Throttler in src/kudu/util/throttler.h, does it meet the usage? -- To view, visit http://gerrit.cloudera.org:8080/19479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f4834bfb0718a2b6b1d946975287a11f6be1fe3 Gerrit-Change-Number: 19479 Gerrit-PatchSet: 5 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 15 Sep 2023 11:24:04 +0000 Gerrit-HasComments: Yes
