Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 )
Change subject: [KUDU-3447] Limit tablets copying speed ...................................................................... Patch Set 10: (5 comments) http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tools/kudu-tool-test.cc@9359 PS9, Line 9359: NO_FATALS(CreateTableWithFlushedData("table1", mini_cluster_.get(), 3, 1)); : int source_tserver_tablet_count = mini_cluster_->mini_tablet_server(0)->Lis > Why create 2 tables? I guess you aim to make both of the 2 tservers have so Done http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tools/kudu-tool-test.cc@9361 PS9, Line 9361: RT_TRUE(source_tserver_tabl > Then check source_tserver_tablet_count doesn't equal to 0. Done http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tools/kudu-tool-test.cc@9375 PS9, Line 9375: "-fs_data_dirs=$2 -fs_wal_dir=$3 -num_threads=3 " : "-tablet_copy_throttler_bytes_per_sec=$4 > The test is just to verify the 2 flags are valid, but dosen't verify the ra Done http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tserver/tablet_copy_client.h File src/kudu/tserver/tablet_copy_client.h: http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tserver/tablet_copy_client.h@355 PS9, Line 355: // in a temporary local file 'superblock_path' and then loaded into the memory. > I think the LocalTabletCopyClient has the same requirement as well, how abo Done http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tserver/tablet_copy_client.cc File src/kudu/tserver/tablet_copy_client.cc: http://gerrit.cloudera.org:8080/#/c/19479/9/src/kudu/tserver/tablet_copy_client.cc@1008 PS9, Line 1008: dst_tablet_copy_metrics_->bytes_fetched->IncrementBy(chunk_size); > How about adding LOG_TIMING when throttle happened? Done -- To view, visit http://gerrit.cloudera.org:8080/19479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f4834bfb0718a2b6b1d946975287a11f6be1fe3 Gerrit-Change-Number: 19479 Gerrit-PatchSet: 10 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Wed, 20 Sep 2023 10:00:00 +0000 Gerrit-HasComments: Yes
