Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20528 )
Change subject: WIP [rpc] Set rpc_max_message_size per available memory to accomodate huge response payloads ...................................................................... Patch Set 2: Code-Review-1 (2 comments) The unlimited default for the flag should be specific only for the CLI tools (i.e. the that specific KRPC client), not for the servers. FYI: there is SetCommandLineOptionWithMode() call that could be used for that purpose. As an example, you could see how it's used in master_runner.cc http://gerrit.cloudera.org:8080/#/c/20528/2/src/kudu/rpc/transfer.cc File src/kudu/rpc/transfer.cc: http://gerrit.cloudera.org:8080/#/c/20528/2/src/kudu/rpc/transfer.cc@41 PS2, Line 41: false No, we want to keep it enabled. http://gerrit.cloudera.org:8080/#/c/20528/2/src/kudu/rpc/transfer.cc@46 PS2, Line 46: 0 No, this should be still limited. -- To view, visit http://gerrit.cloudera.org:8080/20528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c92e5469f806c827a8353fdf6de5a24a221613c Gerrit-Change-Number: 20528 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 02 Oct 2023 16:07:45 +0000 Gerrit-HasComments: Yes
