Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20528 )
Change subject: WIP [rpc] Set rpc_max_message_size per available memory to accomodate huge response payloads ...................................................................... Patch Set 2: -Code-Review > Thanks for the review, Alexey. > I have raised a separate WIP gerrit review to address your comment. > I am yet to complete self-review and unit testing. As of now, this > is only for your reference. > > Could you please take a cursory look and verify whether this is the > right approach. > https://gerrit.cloudera.org/#/c/20535/ Thank you for addressing the feedback! Yes, that patch looks good to me overall, but please address a few nits. If you still want to update comments, etc. for some of the flags like you did in this changelist, feel free to do so, but please do so in a separate changelist. The idea is to keep semantically separate things in different patches. Thanks a lot! -- To view, visit http://gerrit.cloudera.org:8080/20528 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9c92e5469f806c827a8353fdf6de5a24a221613c Gerrit-Change-Number: 20528 Gerrit-PatchSet: 2 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 04 Oct 2023 18:33:40 +0000 Gerrit-HasComments: No
