Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/20525 )
Change subject: WIP [catalog_manager] fix incompatibility with KUDU-2671 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20525/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/20525/1/src/kudu/master/catalog_manager.cc@716 PS1, Line 716: ConvertFromLegacy Do you think it would be worth it to split this method into two, one for the upper bound and one for the lower bound? That way, we can know exactly which partition key was changed from the legacy way to the new way from the log messages. -- To view, visit http://gerrit.cloudera.org:8080/20525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45df424770a09cf7c94f5e1d390757f29f9fb3f4 Gerrit-Change-Number: 20525 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 02 Oct 2023 21:13:34 +0000 Gerrit-HasComments: Yes
