Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20525 )
Change subject: KUDU-3515: fix incompatibility introduced with KUDU-2671 ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/20525/1/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/20525/1/src/kudu/master/catalog_manager.cc@716 PS1, Line 716: ConvertFromLegacy > Do you think it would be worth it to split this method into two, one for th That information is deducible from the information on the tablet's ranges: the conversion only happens for the unbounded end of a partition. With that, I'm not sure it's worth it. However, to address the essence of your concern (if I understood it correctly), I added INFO log into the ConvertFromLegacy() method itself: that's to log old and new keys upon converting either side of a tablet's boundaries. I hope the code in the new revision makes sense. -- To view, visit http://gerrit.cloudera.org:8080/20525 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45df424770a09cf7c94f5e1d390757f29f9fb3f4 Gerrit-Change-Number: 20525 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 03 Oct 2023 18:59:16 +0000 Gerrit-HasComments: Yes
