Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/20535 )
Change subject: WIP [CLI] Set rpc_max_message_size per available memory to accomodate huge response payloads ...................................................................... Patch Set 1: (20 comments) http://gerrit.cloudera.org:8080/#/c/20535/1//COMMIT_MSG Commit Message: PS1: > For git commit messages, please follow the 'generic git commit guidelines a Thank you, Alexey. I am anyway going to re-arrange (when I will make all these corrections) this a little bit before removing WIP. http://gerrit.cloudera.org:8080/#/c/20535/1//COMMIT_MSG@7 PS1, Line 7: accomodate > nit: accommodate Done http://gerrit.cloudera.org:8080/#/c/20535/1//COMMIT_MSG@10 PS1, Line 10: rpc > nit: RPC Done http://gerrit.cloudera.org:8080/#/c/20535/1//COMMIT_MSG@11 PS1, Line 11: add > nit: adds Done http://gerrit.cloudera.org:8080/#/c/20535/1//COMMIT_MSG@11 PS1, Line 11: rpc > nit: RPC Done http://gerrit.cloudera.org:8080/#/c/20535/1//COMMIT_MSG@12 PS1, Line 12: rpc > nit: RPC Done http://gerrit.cloudera.org:8080/#/c/20535/1//COMMIT_MSG@13 PS1, Line 13: accomodate > nit: accommodate Done http://gerrit.cloudera.org:8080/#/c/20535/1//COMMIT_MSG@16 PS1, Line 16: atleast > nit: at least Done http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc File src/kudu/tools/tool_main.cc: http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@255 PS1, Line 255: or > nit: and Done http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@255 PS1, Line 255: d > nit: add a period in the end of the sentence Done http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@256 PS1, Line 256: Return value > nit: The return value ? Done http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@256 PS1, Line 256: s > nit: add a period in the end of the sentence Done http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@260 PS1, Line 260: kudu::process_memory::CurrentConsumption()) > For simplicity, consider dropping this part: I guess it's not going to be d In my tests, the value comes around 600K - 700K usually. But that is still negligible as compared to HardLimit which is in GBs and that is usually going to be the case. So, it should be ok to ignore CurrentConsumption. http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@274 PS1, Line 274: rpc > nit: RPC Done http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@275 PS1, Line 275: a rpc > nit: an RPC ? Done http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@275 PS1, Line 275: accomodate > accommodate Done http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@277 PS1, Line 277: int64_t > nit: consider adding 'const' to express that this is an invariant in this s Done http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@283 PS1, Line 283: atleast > nit: at least ? Done http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@284 PS1, Line 284: rpc > nit: RPC used exact flag name instead i.e. rpc_max_message_size http://gerrit.cloudera.org:8080/#/c/20535/1/src/kudu/tools/tool_main.cc@286 PS1, Line 286: int64_t > nit: consider adding 'const' to express that this is an invariant in this s Done -- To view, visit http://gerrit.cloudera.org:8080/20535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic27b494bc1fde46c2a095c7291fc840a98429068 Gerrit-Change-Number: 20535 Gerrit-PatchSet: 1 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 06 Oct 2023 09:11:48 +0000 Gerrit-HasComments: Yes
