Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20535 )
Change subject: [CLI] Set rpc_max_message_size to accommodate huge response payloads ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/20535/2/src/kudu/tools/tool_main.cc File src/kudu/tools/tool_main.cc: http://gerrit.cloudera.org:8080/#/c/20535/2/src/kudu/tools/tool_main.cc@264 PS2, Line 264: int64_t max_memory_available = kudu::process_memory::MaxMemoryAvailable(); > Note: I noticed from a couple of test failures (RaftConsensusITest.TestEarl I guess the observed behavior might be related to the fact that current test mini-cluster uses the kudu CLI to start kudu-master and kudu-tserver for tests: `kudu test mini_cluster ...`. http://gerrit.cloudera.org:8080/#/c/20535/3/src/kudu/util/process_memory.cc File src/kudu/util/process_memory.cc: http://gerrit.cloudera.org:8080/#/c/20535/3/src/kudu/util/process_memory.cc@219 PS3, Line 219: int64_t MaxMemoryAvailable() { : int64_t total_ram; : CHECK_OK(Env::Default()->GetTotalRAMBytes(&total_ram)); : // We will use 80% of system RAM to align with default hard limit. : total_ram = total_ram * 4; : total_ram /= 5; : : return total_ram; : } Once this new function is introduced, does it make sense to use it in DoInitLimits() instead of duplicating the same code here and there? -- To view, visit http://gerrit.cloudera.org:8080/20535 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic27b494bc1fde46c2a095c7291fc840a98429068 Gerrit-Change-Number: 20535 Gerrit-PatchSet: 3 Gerrit-Owner: Ashwani Raina <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 09 Oct 2023 22:37:09 +0000 Gerrit-HasComments: Yes
