Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.h File src/kudu/fs/log_block_manager-test-util.h: http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.h@177 PS2, Line 177: // Use DataDirManager to access the Dir objects conveniently. : DataDirManager* dd_manager_; Seems this object is not so necessary to be introduced in the base class(at least in this patch's scope). Is it possible to include it only in a specific derived class? If not, maybe just include these changes in the relevant patch? http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc File src/kudu/fs/log_block_manager-test-util.cc: http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc@66 PS2, Line 66: max_malformed_types_ = 7; nit: Could we initialize max_malformed_types_ in the .h file? It may be easier to find out why it should be 7. http://gerrit.cloudera.org:8080/#/c/20504/2/src/kudu/fs/log_block_manager-test-util.cc@233 PS2, Line 233: RETURN_NOT_OK(metadata_writer->Close()); : return Status::OK(); nit: Replace these with 'return metadata_writer->Close()'? Same as other places. -- To view, visit http://gerrit.cloudera.org:8080/20504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5 Gerrit-Change-Number: 20504 Gerrit-PatchSet: 2 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Sat, 07 Oct 2023 11:33:14 +0000 Gerrit-HasComments: Yes
