Yuqi Du has posted comments on this change. ( http://gerrit.cloudera.org:8080/20504 )
Change subject: KUDU-3371 [fs] make LBMCorruptor a base class ...................................................................... Patch Set 3: Verified+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/20504/3/src/kudu/fs/log_block_manager-test-util.h File src/kudu/fs/log_block_manager-test-util.h: http://gerrit.cloudera.org:8080/#/c/20504/3/src/kudu/fs/log_block_manager-test-util.h@155 PS3, Line 155: // 'error_type' is in the following types of errors: : // 0. No block offset. : // 1. No block length. : // 2. Negative block offset. : // 3. Negative block length. : // 4. Offset + length > data file size. : // 5. Unrecognized op type. What about consider uniting them into an enum structure ? -- To view, visit http://gerrit.cloudera.org:8080/20504 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a1f2842598f46e88fbd08273d8fd19ed34a9cc5 Gerrit-Change-Number: 20504 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Yuqi Du <[email protected]> Gerrit-Comment-Date: Thu, 12 Oct 2023 10:22:15 +0000 Gerrit-HasComments: Yes
