Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/19479 )
Change subject: [KUDU-3447] Limit tablets copying speed ...................................................................... Patch Set 17: (3 comments) http://gerrit.cloudera.org:8080/#/c/19479/17/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/19479/17/src/kudu/tools/kudu-tool-test.cc@9361 PS17, Line 9361: ASSERT_TRUE(source_tserver_tablet_count > 0); Better to use ASSERT_GT(), the actual value of source_tserver_tablet_count will be output if the ASSERT_* failed. http://gerrit.cloudera.org:8080/#/c/19479/17/src/kudu/tools/kudu-tool-test.cc@9381 PS17, Line 9381: 10*FLAGS_tablet_copy_transfer_chunk_size_bytes nit: leave a space on both left and right sides of '*'. http://gerrit.cloudera.org:8080/#/c/19479/17/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/19479/17/src/kudu/tools/tool_action_local_replica.cc@334 PS17, Line 334: shared_ptr<Throttler> throttler; : if (FLAGS_tablet_copy_throttler_bytes_per_sec > 0) { : throttler = std::make_shared<Throttler>(MonoTime::Now(), : 0, : FLAGS_tablet_copy_throttler_bytes_per_sec, : FLAGS_tablet_copy_throttler_burst_factor); : } : The throttler is only used in CLI tool? How about create a throttler internal of the cluster as well, use for replicas migration/auto rebalancing? -- To view, visit http://gerrit.cloudera.org:8080/19479 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f4834bfb0718a2b6b1d946975287a11f6be1fe3 Gerrit-Change-Number: 19479 Gerrit-PatchSet: 17 Gerrit-Owner: Wang Xixu <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Fri, 13 Oct 2023 04:25:51 +0000 Gerrit-HasComments: Yes
