Song Jiacheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 )
Change subject: KUDU-3486 Master periodically request for full reports. ...................................................................... Patch Set 5: (2 comments) Thank you for the review! http://gerrit.cloudera.org:8080/#/c/20600/5/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/20600/5/src/kudu/master/master_service.cc@495 PS5, Line 495: ts_desc->UpdateNeedsFullTabletReport(true); > It looks like a full tablet report will happen only when a new tablet is ad Thank you for the review! Actually, the solution in our clusters now is as you said, "start a background thread in the tablet server and clear the tombed replica periodically". But what we want to delete is that the tombstoned replicas of the tablet which had already been deleted. The background thread in tablet server does not know which tablets have been deleted already. And yes, the operation does cost a lot, so I set the interval to 6 hours by default, or even larger is ok. http://gerrit.cloudera.org:8080/#/c/20600/5/src/kudu/master/ts_descriptor.cc File src/kudu/master/ts_descriptor.cc: http://gerrit.cloudera.org:8080/#/c/20600/5/src/kudu/master/ts_descriptor.cc@169 PS5, Line 169: last_full_report_ > nit: last_full_report_time_ Done -- To view, visit http://gerrit.cloudera.org:8080/20600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b Gerrit-Change-Number: 20600 Gerrit-PatchSet: 5 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Tue, 24 Oct 2023 09:25:56 +0000 Gerrit-HasComments: Yes
