Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20600 )
Change subject: KUDU-3486 Master periodically request for full reports. ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/20600/9/src/kudu/master/master-test.cc File src/kudu/master/master-test.cc: http://gerrit.cloudera.org:8080/#/c/20600/9/src/kudu/master/master-test.cc@3779 PS9, Line 3779: TEST_F(MasterTest, TestPeriodicalFullReport) { Could you create some tombstoned replicas and then ask a full report to make sure the tombstoned replicas will be deleted? http://gerrit.cloudera.org:8080/#/c/20600/9/src/kudu/master/master_service.cc File src/kudu/master/master_service.cc: http://gerrit.cloudera.org:8080/#/c/20600/9/src/kudu/master/master_service.cc@129 PS9, Line 129: ask nit: Whether the master asks full report from the tablet servers through heart-beating. http://gerrit.cloudera.org:8080/#/c/20600/9/src/kudu/master/master_service.cc@136 PS9, Line 136: master_periodically_ask_full_report_interval_sec How about using only one flag --master_periodically_ask_full_report_interval_sec and removing --master_periodically_ask_full_report. When the value of --master_periodically_ask_full_report_interval_sec is 0, disable the feature? -- To view, visit http://gerrit.cloudera.org:8080/20600 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92d3b3e44f49ad24a95fa10f351c6bd55c6eca7b Gerrit-Change-Number: 20600 Gerrit-PatchSet: 9 Gerrit-Owner: Song Jiacheng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Song Jiacheng <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Sun, 05 Nov 2023 02:36:01 +0000 Gerrit-HasComments: Yes
