Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20628 )
Change subject: KUDU-3519: List masters in /dump-entities ...................................................................... Patch Set 1: (1 comment) Overall looks good to me, thanks for the patch! Did download and build the patch, checked manually that the endpoint displays the masters. To avoid this manual process, could you please add a test in 'TEST_F(MasterTest, TestRegisterAndHeartbeat)' similar to: https://github.com/apache/kudu/blob/master/src/kudu/master/master-test.cc#L632-L655 Just to have basic sanity checks? Thank you! http://gerrit.cloudera.org:8080/#/c/20628/1/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/20628/1/src/kudu/master/master_path_handlers.cc@780 PS1, Line 780: use_externa-addr nit: use_external_addr -- To view, visit http://gerrit.cloudera.org:8080/20628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92ab8057c5bdae6e8b41afc8f19c0a72cfa329a2 Gerrit-Change-Number: 20628 Gerrit-PatchSet: 1 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 26 Oct 2023 14:51:56 +0000 Gerrit-HasComments: Yes
