Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20628 )
Change subject: KUDU-3519: List masters in /dump-entities ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20628/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20628/1//COMMIT_MSG@7 PS1, Line 7: KUDU-3519: List masters in /dump-entities > Is it convenient to add a unit test? Done http://gerrit.cloudera.org:8080/#/c/20628/1/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/20628/1/src/kudu/master/master_path_handlers.cc@780 PS1, Line 780: > nit: use_external_addr Done http://gerrit.cloudera.org:8080/#/c/20628/1/src/kudu/master/master_path_handlers.cc@782 PS1, Line 782: jw.StartArray(); > Please LOG(WARNING) the error information. Done -- To view, visit http://gerrit.cloudera.org:8080/20628 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I92ab8057c5bdae6e8b41afc8f19c0a72cfa329a2 Gerrit-Change-Number: 20628 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Comment-Date: Fri, 03 Nov 2023 10:46:08 +0000 Gerrit-HasComments: Yes
