Halim Kim has posted comments on this change. ( http://gerrit.cloudera.org:8080/20278 )
Change subject: KUDU-3496 support spnego dedicated keytab ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/20278/3/src/kudu/security/gssapi.cc File src/kudu/security/gssapi.cc: http://gerrit.cloudera.org:8080/#/c/20278/3/src/kudu/security/gssapi.cc@137 PS3, Line 137: if (!FLAGS_spnego_keytab_file.empty()) { > Is this code executed in every step SpnegoStep call? Is it intended? Today, I read the krb5_gss_register_acceptor_identity function spec once again and found that there is no need to run this function in every SpnegoStep. I guess it is fine to put krb5_gss_register_acceptor_identity in start function of Webserver class so that the function will be called only one time. I will test it and share the result. thank you for your comment. -- To view, visit http://gerrit.cloudera.org:8080/20278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01646207954854d67308f99e6b71ba32c019ed6a Gerrit-Change-Number: 20278 Gerrit-PatchSet: 4 Gerrit-Owner: Halim Kim <[email protected]> Gerrit-Reviewer: Halim Kim <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Fri, 27 Oct 2023 13:12:22 +0000 Gerrit-HasComments: Yes
