Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20278 )
Change subject: KUDU-3496 support spnego dedicated keytab ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/20278/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20278/6//COMMIT_MSG@14 PS6, Line 14: even --webserver_require_spnego even --webserver_require_spnego=true? http://gerrit.cloudera.org:8080/#/c/20278/6/src/kudu/security/test/mini_kdc.h File src/kudu/security/test/mini_kdc.h: http://gerrit.cloudera.org:8080/#/c/20278/6/src/kudu/security/test/mini_kdc.h@95 PS6, Line 95: CreateServiceKeytabWithName Could you give some comments about this function? http://gerrit.cloudera.org:8080/#/c/20278/6/src/kudu/security/test/mini_kdc.cc File src/kudu/security/test/mini_kdc.cc: http://gerrit.cloudera.org:8080/#/c/20278/6/src/kudu/security/test/mini_kdc.cc@283 PS6, Line 283: string kt_path = name; : kt_path = JoinPathSegments(options_.data_root, kt_path) + ".keytab"; How about: string kt_path = JoinPathSegments(options_.data_root, name) + ".keytab"; http://gerrit.cloudera.org:8080/#/c/20278/6/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/20278/6/src/kudu/server/webserver-test.cc@259 PS6, Line 259: FLAGS_spnego_keytab_file = kt_path; Should test another case, which FLAGS_spnego_keytab_file is empty? -- To view, visit http://gerrit.cloudera.org:8080/20278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I01646207954854d67308f99e6b71ba32c019ed6a Gerrit-Change-Number: 20278 Gerrit-PatchSet: 6 Gerrit-Owner: Halim Kim <[email protected]> Gerrit-Reviewer: Halim Kim <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Wang Xixu <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 09 Nov 2023 09:55:43 +0000 Gerrit-HasComments: Yes
