Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20631 )
Change subject: KUDU-3520 Fix file descriptor leak in encryption ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/20631/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/20631/1/src/kudu/util/env_posix.cc@1569 PS1, Line 1569: MAYBE_RETURN_EIO(fname, IOError(Env::kInjectedFailureStatusMsg, EIO)); > +1 How do you propose to do this? I need to pass the encryption header to the files when constructing them which are not available yet and move constructors can't have other parameters unless they also have default values. http://gerrit.cloudera.org:8080/#/c/20631/1/src/kudu/util/env_posix.cc@2359 PS1, Line 2359: } > Although this is not encryption related, but it's needed to close the fd as Done http://gerrit.cloudera.org:8080/#/c/20631/1/src/kudu/util/env_posix.cc@2366 PS1, Line 2366: unique_ptr<char[]> fname(new char[name_template.size() + > +1 Done -- To view, visit http://gerrit.cloudera.org:8080/20631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2412429d4fe836b705296e9e30453d7c4d030cec Gerrit-Change-Number: 20631 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 02 Nov 2023 23:07:11 +0000 Gerrit-HasComments: Yes
