Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20631 )
Change subject: KUDU-3520 Fix file descriptor leak in encryption ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/20631/1/src/kudu/util/env_posix.cc File src/kudu/util/env_posix.cc: http://gerrit.cloudera.org:8080/#/c/20631/1/src/kudu/util/env_posix.cc@1569 PS1, Line 1569: unique_ptr<SequentialFile>* result) override { > tbh it does feel a little weird to do it that way. Can't use a simple move I think introducing those extra classes is better to be done in a separate patch -- that would be easier to reason about and review. It could end up in an uglier code, and then it would be obvious to everyone it wasn't a good idea at all :) So, the current approach as of PS3 looks good to me as-is, given Yingchun's feedback on PS2 has been addressed. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/20631 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2412429d4fe836b705296e9e30453d7c4d030cec Gerrit-Change-Number: 20631 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 13 Nov 2023 18:20:45 +0000 Gerrit-HasComments: Yes
