Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18029 )
Change subject: [tools] KUDU-3337 Add unsafe_create_cmeta tool ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/18029/6/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/18029/6/src/kudu/tools/kudu-tool-test.cc@18 PS6, Line 18: #include <sys/stat. > nit: replace with <climits> C++ header file Done http://gerrit.cloudera.org:8080/#/c/18029/3/src/kudu/tools/tool_action_local_replica.cc File src/kudu/tools/tool_action_local_replica.cc: http://gerrit.cloudera.org:8080/#/c/18029/3/src/kudu/tools/tool_action_local_replica.cc@675 PS3, Line 675: > I guess it's possible to have a situation when there was still a majority o Makes sense, added it. http://gerrit.cloudera.org:8080/#/c/18029/3/src/kudu/tools/tool_action_local_replica.cc@678 PS3, Line 678: : Status UnsafeRecreateCmeta(const RunnerContext& context) { : const string& tablet_id = FindOrDie(context.required_args, kTabletIdArg); : int64_t term; : int64_t opid_index; > It seems this comment isn't addressed as of PS6. Or the idea is to address Oops sorry forgot to address it. -- To view, visit http://gerrit.cloudera.org:8080/18029 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I136cc5b5797420a9ca9156f37c3e281da0c265d7 Gerrit-Change-Number: 18029 Gerrit-PatchSet: 7 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 06 Nov 2023 21:09:57 +0000 Gerrit-HasComments: Yes
